HomePhabricator

wallet: Fix non-determinism in ParseHDKeypath(...). Avoid using an…

Description

wallet: Fix non-determinism in ParseHDKeypath(...). Avoid using an uninitialized variable in path calculation.

Summary:

  • wallet: Add error handling. Check return value of ParseUInt32(...) in ParseHDKeypath(...).
  • wallet: Add tests for ParseHDKeypath(...)

This is a backport of Core PR13712

Test Plan:

make check

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D4500

Details

Provenance
practicalswift <practicalswift@users.noreply.github.com>Authored on Jul 19 2018, 08:30
deadalnixCommitted on Nov 21 2019, 23:07
deadalnixPushed on Nov 21 2019, 23:07
Reviewer
Restricted Project
Differential Revision
D4500: wallet: Fix non-determinism in ParseHDKeypath(...). Avoid using an uninitialized variable in path calculation.
Parents
rABC93aa869bfd7e: Generalize PublicOnlySigningProvider into HidingSigningProvider
Branches
Unknown
Tags
Unknown