HomePhabricator

[land-bot] Queue the HEAD revision by default

Description

[land-bot] Queue the HEAD revision by default

Summary:
The landbot workflow fails on stacked revisions unless --revision
is explicitly set. Users should expect it to work out of the box. This patch
picks the latest revision in the current branch by default, eliminating this
annoyance for small stacks.

While it might be more ideal to queue all revisions in the stack at once,
this requires some refactoring to get rid of the dependency on using arc land
as a child workflow. In theory, this patch also acts as the first step toward
eliminating that dependency, so we're likely moving in the right direction.

Test Plan:
On a set of stacked revisions:

arc land-via-bot --hold

Pre-patch: The above fails, complaining about detecting multiple revisions.
Post-patch: The output indicates the latest revision is selected for landing.

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7920

Details

Provenance
jasonbcoxAuthored on Oct 15 2020, 16:32
abc-botPushed on Oct 15 2020, 16:38
Reviewer
Restricted Project
Differential Revision
D7920: [land-bot] Queue the HEAD revision by default
Parents
rABC5d4729852ad9: HTML escape the wallet name in dialogs and notifications
Branches
Unknown
Tags
Unknown