HomePhabricator

Replace CombineSignatures with ProduceSignature

Authored by Andrew Chow <achow101-github@achow101.com> on Jun 8 2018, 04:12.

Description

Replace CombineSignatures with ProduceSignature

Summary:
Instead of using CombineSignatures to create the final scriptSig or
scriptWitness of an input, use ProduceSignature itself.

To allow for ProduceSignature to place signatures, pubkeys, and scripts
that it does not know about, we pass down the SignatureData to SignStep
which pulls out the information that it needs from the SignatureData.

This is a partial backport of Core PR13425 : https://github.com/bitcoin/bitcoin/pull/13425/commits/ed94c8b556dbbfb62452eaefd9ee7841df09777a

Depends on D4205 and D4210

Test Plan:

make check
./test/functional/test_runner.py

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D4211

Details

Committed
deadalnixFri, Oct 4, 21:54
Pushed
deadalnixFri, Oct 4, 21:54
Reviewer
Restricted Project
Differential Revision
D4211: Replace CombineSignatures with ProduceSignature
Parents
rABCae1211c395eb: Make SignatureData able to store signatures and scripts
Branches
Unknown
Tags
Unknown