HomePhabricator

Remove timing-based signature cache unit test
a90689ff9880Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Remove timing-based signature cache unit test

Two changes:

First removes a unit test that fails in my development environment
(OSX, compiled -g3 with clang).

sipa says that's not terribly surprising; the CMutableTransaction change
makes signing a little more expensive but verification quicker. The unit
test timed sign+verify-uncached versus verify-cached-five-times.

He also says the test will be invalid when libsec256kp1 is integrated
(because validation is super-optimized over signing).

core.h change fixes a compiler warning (clang -Wall : CMutableTransaction defined
as struct, declared as class in script.h).

Details

Provenance
Gavin Andresen <gavinandresen@gmail.com>Authored on Jun 25 2014, 18:21
deadalnixPushed on May 14 2017, 22:04
Parents
rABC343feecf562a: Merge pull request #4368
Branches
Unknown
Tags
Unknown

Event Timeline

Gavin Andresen <gavinandresen@gmail.com> committed rABCa90689ff9880: Remove timing-based signature cache unit test (authored by Gavin Andresen <gavinandresen@gmail.com>).Jun 25 2014, 18:57