clang-tidy: cover fuzzers and chronik cpp code
Summary:
Trying to run a clang-tidy build on all code raises a few warnings as errors currently. Fix these errors and add chronik and bitcoin-fuzzers to the clang-tidy build on CI
/home/pierre/dev/bitcoin-abc/chronik/test/chronikbridge_tests.cpp:95:9: error: Called C++ object pointer is null [clang-analyzer-core.CallAndMessage,-warnings-as-errors]
WITH_LOCK(chainman.GetMutex(), return chainman.ActiveTip())
^Test Plan:
cmake .. -GNinja -DBUILD_CHRONIK=1 -DENABLE_CLANG_TIDY=ON -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ ninja all check bitcoin-fuzzers bench-bitcoin
Reviewers: #bitcoin_abc, Fabien
Reviewed By: #bitcoin_abc, Fabien
Differential Revision: https://reviews.bitcoinabc.org/D18660