HomePhabricator

Remove NumBlocksOfPeers
aa250f045302Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Remove NumBlocksOfPeers

Generally useless information. Only updates on connect time, not after
that. Peers can easily lie and the median filter is not effective in
preventing that.

In the past it was used for progress display in the GUI but
CheckPoints::guessVerificationProgress provides a better way that is now used.
It was too easy to mislead it. Peers do lie about it in practice, see issue #4065.

From the RPC, getpeerinfo gives the peer raw values, which are more
useful.

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on May 5 2014, 17:43
deadalnixPushed on May 14 2017, 22:04
Parents
rABCd4ffe4e425b5: Merge pull request #4120
Branches
Unknown
Tags
Unknown

Event Timeline

Wladimir J. van der Laan <laanwj@gmail.com> committed rABCaa250f045302: Remove NumBlocksOfPeers (authored by Wladimir J. van der Laan <laanwj@gmail.com>).May 6 2014, 09:09