HomePhabricator

[python linting] Enforce all flake8 F codes

Description

[python linting] Enforce all flake8 F codes

Summary:
Analogous to D5198, this turns on all the pyflakes checks
in flake8. But we don't need any exceptions because we had
pretty much all F codes listed anyway.

The only ones we didn't have explicitly listed:

F721 	syntax error in doctest
F722 	syntax error in forward annotation
F723 	syntax error in type comment
F901 	raise NotImplemented should be raise NotImplementedError

https://flake8.pycqa.org/en/latest/user/error-codes.html
https://github.com/PyCQA/pyflakes/blob/master/NEWS.rst

I've checked with a variety of versions of flake8 (/pyflakes) and
they all pass.

Test Plan:

arc lint --everything

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5205

Details

Provenance
Mark Lundeberg <markblundeberg@users.noreply.github.com>Authored on Feb 7 2020, 16:14
markblundebergPushed on Feb 7 2020, 16:42
Reviewer
Restricted Project
Differential Revision
D5205: [python linting] Enforce all flake8 F codes
Parents
rABCbb3ad402c4d5: [LINTER] Prevent using inline doxygen comments on their own line
Branches
Unknown
Tags
Unknown

Event Timeline

Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABCaae6d8a5aeb0: [python linting] Enforce all flake8 F codes (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).Feb 7 2020, 16:41