HomePhabricator

Increase timeout waiting for pruned blk00000.dat
ac40ed780079Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Increase timeout waiting for pruned blk00000.dat

In my ever-growing list of test failures, I was seeing this one intermittently.

Running 2nd level testscript pruning.py...
Initializing test directory /tmp/testY5ypCv
Warning! This test requires 4GB of disk space and takes over 30 mins (up to 2 hours)
Mining a big blockchain of 995 blocks
Check that we haven't started pruning yet because we're below PruneAfterHeight
Success
Though we're already using more than 550MB, current usage: 587
Mining 25 more blocks should cause the first block file to be pruned
Assertion failed: blk00000.dat not pruned when it should be
  File "/home/error/bitcoinxt-0.11D/qa/rpc-tests/test_framework/test_framework.py", line 118, in main
    self.run_test()
  File "/home/error/bitcoinxt-0.11D/qa/rpc-tests/pruning.py", line 272, in run_test
    self.test_height_min()
  File "/home/error/bitcoinxt-0.11D/qa/rpc-tests/pruning.py", line 94, in test_height_min
    raise AssertionError("blk00000.dat not pruned when it should be")
Stopping nodes
Failed

After digging into the test, I found that the code is waiting 10 seconds for blk00000.dat to be deleted, and then throwing this failure if it still exists after 10 seconds.

I increased this amount, had the script print the actual time taken, and ran the test a few more times. The time taken ranged between 8 to 12 seconds. So, I feel that this timeout is too short.

After changing the timeout to 30 seconds, the test passes consistently.
(cherry picked from commit 3469911c89a48dd2fefe4d1c2a0c176256e14ee0)

Details

Provenance
error10 <error@ioerror.us>Authored on Dec 4 2015, 19:00
MarcoFalke <falke.marco@gmail.com>Committed on May 10 2016, 15:49
deadalnixPushed on May 14 2017, 22:04
Parents
rABCb33824b76cbf: Merge #8012: Qt: Delay user confirmation of send
Branches
Unknown
Tags
Unknown

Event Timeline

MarcoFalke <falke.marco@gmail.com> committed rABCac40ed780079: Increase timeout waiting for pruned blk00000.dat (authored by error10 <error@ioerror.us>).May 10 2016, 15:49