HomePhabricator

gui: Ensure tx send error highlight is visible

Description

gui: Ensure tx send error highlight is visible

Summary:
If sending to multiple recipients and one of the recipient fields is malformed,
the highlighted field may not be visible due to being scrolled out of view,
leading to a confusing lack of error feedback when clicking Send. To avoid this
problem ensure the first field containing an error is scrolled into view
when Send is clicked.

Backport of Core PR16694

Test Plan:
ninja && ninja check
In bitcoin-qt, create a transaction with multiple recipients, add a mistake to
an address that is scrolled out of view, click send.

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7904

Details

Provenance
bpay <bpay@users.noreply.github.com>Authored on Dec 14 2018, 04:39
PiRKCommitted on Oct 14 2020, 06:56
PiRKPushed on Oct 14 2020, 06:56
Reviewer
Restricted Owners Package
Differential Revision
D7904: gui: Ensure tx send error highlight is visible
Parents
rABC8c361009afdd: Merge #18487: rpc: Fix rpcRunLater race in walletpassphrase
Branches
Unknown
Tags
Unknown