HomePhabricator

Remove mempool global from p2p

Description

Remove mempool global from p2p

Summary:
PR description:

This refactor unlocks some nice potential features, such as, but not limited to:

  • Removing the fee estimates global (would avoid slightly fragile workarounds such as Disable fee estimation in blocksonly mode (by removing the fee estimates global) #18766)
  • Making the mempool optional for a "blocksonly" operation mode

Even absent those features, the new code without the global should be easier to maintain, read and write tests for.

This is a backport of core#19556 [2/3]
https://github.com/bitcoin/bitcoin/pull/19556/commits/fa0359c5b30730744aa8a7cd9ffab79ded91041f

Depends on D9788

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D9789

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Jul 19 2020, 12:52
PiRKCommitted on Jul 15 2021, 11:58
PiRKPushed on Jul 15 2021, 11:58
Reviewer
Restricted Project
Differential Revision
D9789: Remove mempool global from p2p
Parents
rABCd5099f490d7a: Remove mempool global from init
Branches
Unknown
Tags
Unknown

Event Timeline