HomePhabricator

refactor: Pass block reference instead of pointer to PeerManagerImpl…

Description

refactor: Pass block reference instead of pointer to PeerManagerImpl::BlockRequested

Summary:
This allows to remove an assert and at the same time make it more obvious that the block is never nullptr.

This is a backport of core#22221

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D12714

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Jun 11 2021, 07:56
PiRKCommitted on Dec 1 2022, 10:49
PiRKPushed on Dec 1 2022, 10:49
Reviewer
Restricted Project
Differential Revision
D12714: refactor: Pass block reference instead of pointer to PeerManagerImpl::BlockRequested
Parents
rABC315b69ee6a34: [Cashtab] [Simplify wallet structure p8] Remove debug logging
Branches
Unknown
Tags
Unknown