HomePhabricator

Move some static functions out of wallet.h/cpp

Authored by Russell Yanofsky <russ@yanofsky.org> on Sep 27 2018, 14:31.

Description

Move some static functions out of wallet.h/cpp

Summary:
Backport of Core PR10976

This change is desirable because wallet.h/cpp are monolithic and hard to
navigate, so pulling things out and grouping together pieces of related
functionality should improve the organization.

Another proximate motivation is the wallet process separation work in
https://github.com/bitcoin/bitcoin/pull/10973, where (at least initially)
parameter parsing and fee estimation are still done in the main process rather
than the wallet process, and having functions that run in different processes
scrambled up throughout wallet.cpp is unnecessarily confusing.

Test Plan:

make check

Reviewers: #bitcoin_abc, deadalnix, jasonbcox

Reviewed By: #bitcoin_abc, deadalnix, jasonbcox

Subscribers: jasonbcox, deadalnix, teamcity

Differential Revision: https://reviews.bitcoinabc.org/D1785

Details

Committed
schancelSep 27 2018, 14:31
Pushed
schancelSep 27 2018, 14:31
Reviewer
Restricted Project
Differential Revision
D1785: Move some static functions out of wallet.h/cpp
Parents
rABC1c79e0a3d0cc: [cmake] Set the proper flags for Qt mock when the wallet is enabled.
Branches
Unknown
Tags
Unknown

Event Timeline

schancel committed rABCb10e567986f2: Move some static functions out of wallet.h/cpp (authored by Russell Yanofsky <russ@yanofsky.org>).Sep 27 2018, 14:31