refactor: Extract ParseOpCode from ParseScript
b2738e030547
Actions

Description

refactor: Extract ParseOpCode from ParseScript

Summary:
Seems more natural to have mapOpNames "hidden" in ParseOpCode than in ParseScript.

A second lookup in mapOpNames is also removed.

This is a backport of core#19851

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10812

Details

Provenance

Joo Barbosa <joao.paulo.barbosa@gmail.com>	Authored on Aug 31 2020, 18:29
PiRK	Committed on Jan 11 2022, 16:40
PiRK	Pushed on Jan 11 2022, 16:40

Reviewer

Restricted Project

Differential Revision

D10812: refactor: Extract ParseOpCode from ParseScript

Parents

rABC71149ac5022a: net: Use Span in ReceiveMsgBytes

Branches

Unknown

Tags

Unknown

Event Timeline

PiRK committed rABCb2738e030547: refactor: Extract ParseOpCode from ParseScript (authored by Joo Barbosa <joao.paulo.barbosa@gmail.com>).Jan 11 2022, 16:40

PiRK added an edge: D10812: refactor: Extract ParseOpCode from ParseScript.

teamcity mentioned this in T2154: Build Bitcoin-ABC / Master / Clang 10 is broken..Jan 11 2022, 16:56

Changes (2)

Path

Size

src/

core_read.cpp

test/

util/

data/

bitcoin-util-test.json

rABCb2738e030547

View Options

src/core_read.cpp