HomePhabricator

refactor: Get rid of Wallet::IsWalletFlagSet method

Description

refactor: Get rid of Wallet::IsWalletFlagSet method

Summary:
Replace by privateKeysDisabled method to avoid need for GUI to reference
internal wallet flags.

Also remove adjacent WalletModel canGetAddresses wrapper that serves no purpose
and make Wallet::canGetAddresses non-const so it can be implemented by IPC
classes in #10102.

Backport of Core PR18278 part [1/6] : https://github.com/bitcoin/bitcoin/pull/18278/commits/77e4b0657298c715c835d8d2eb11e173852e6815

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8019

Details

Provenance
Russell Yanofsky <russ@yanofsky.org>Authored on Dec 5 2017, 20:57
deadalnixCommitted on Oct 21 2020, 14:29
deadalnixPushed on Oct 21 2020, 14:29
Reviewer
Restricted Project
Differential Revision
D8019: refactor: Get rid of Wallet::IsWalletFlagSet method
Parents
rABC48baf4ea7c59: [backport#16865] test: add some unit tests for merkle.cpp
Branches
Unknown
Tags
Unknown