refactor: Replace global find_value function with UniValue::find_value method
b73fa52257e8
Actions

Description

refactor: Replace global find_value function with UniValue::find_value method

Summary:
These warning are very noisy and annoying when working on large refactors, hiding the useful information from the developer.

Backport of core#27605.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D15097

Details

Provenance

MarcoFalke <*~=`'#}+{/-\|&$^_@721217.xyz>	Authored on May 9 2023, 07:21
Fabien	Committed on Jan 5 2024, 16:59
Fabien	Pushed on Jan 5 2024, 16:59

Reviewer

Restricted Project

Differential Revision

D15097: refactor: Replace global find_value function with UniValue::find_value method

Parents

rABC9b7b084a58d9: Fix a -Wmaybe-uninitialized warning in cuckoocache_tests

Branches

Unknown

Tags

Unknown

Event Timeline

Fabien committed rABCb73fa52257e8: refactor: Replace global find_value function with UniValue::find_value method (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).Jan 5 2024, 16:59

Fabien added an edge: D15097: refactor: Replace global find_value function with UniValue::find_value method.

Changes (16)

Path

Size

src/

qt/

rpc/

rawtransaction_util.cpp

test/

univalue/

include/

univalue.h

lib/

univalue.cpp

wallet/

rpcwallet.cpp

rABCb73fa52257e8

View Options

src/bitcoin-cli.cpp

View Options

src/httprpc.cpp

View Options

src/qt/rpcconsole.cpp

View Options

src/rpc/avalanche.cpp

View Options

src/rpc/mining.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/rpc/rawtransaction_util.cpp

View Options

src/rpc/request.cpp

View Options

src/rpc/util.cpp

View Options

src/test/interfaces_tests.cpp

View Options

src/test/key_io_tests.cpp

View Options

src/test/rpc_server_tests.cpp

View Options

src/test/rpc_tests.cpp

View Options

src/univalue/include/univalue.h

View Options

src/univalue/lib/univalue.cpp

View Options

refactor: Replace global find_value function with UniValue::find_value methodb73fa52257e8Actions

Description

Details

Event Timeline

Changes (16)

rABCb73fa52257e8

src/bitcoin-cli.cpp

src/httprpc.cpp

src/qt/rpcconsole.cpp

src/rpc/avalanche.cpp

src/rpc/mining.cpp

src/rpc/rawtransaction.cpp

src/rpc/rawtransaction_util.cpp

src/rpc/request.cpp

src/rpc/util.cpp

src/test/interfaces_tests.cpp

src/test/key_io_tests.cpp

src/test/rpc_server_tests.cpp

src/test/rpc_tests.cpp

src/univalue/include/univalue.h

src/univalue/lib/univalue.cpp

src/wallet/rpcwallet.cpp

refactor: Replace global find_value function with UniValue::find_value method
b73fa52257e8
Actions