[Cashtab] [OP_RETURN msg upgrade] - Pt2 - Use bytecount for unencrypted airdrop messages
Summary:
T3100
Depends on D13729
Updates the max message limit to reflect the reduced OP_RETURN script space for airdrop transactions since the eToken ID is embedded into the OP_RETURN output.
Test Plan:
- calculate an airdrop and click Copy to send screen
- expand the message section and ensure the placeholder text reflects 38 bytes less than the unencrypted message limit
- enter more than 177 bytes and ensure validation error is triggered
- enter a message of 177 or less bytes, click Send and ensure successful broadcast
- navigate away and then back to the Send screen without any airdrop context, and ensure the placeholder text in the message section is showing the full 215 byte limit
- enter a message of 215 bytes or less and ensure no regression
- send a normal XEC tx with no message and ensure no regression
- send a one to many XEC tx with no message and ensure no regression
- send a one to many XEC tx with a 215 byte message and ensure no regression
- grep -r 'unencryptedAirdropMsgByteLimit' src/ and ensure no instances of unencryptedAirdropMsgByteLimit
Reviewers: bytesofman, #bitcoin_abc
Reviewed By: bytesofman, #bitcoin_abc
Differential Revision: https://reviews.bitcoinabc.org/D13807