HomePhabricator

Move cs_main locking annotations from .cpp to .h

Description

Move cs_main locking annotations from .cpp to .h

Summary:
Move cs_main locking annotations from .cpp to .h.

Backport of Bitcoin Core PR14063
https://github.com/bitcoin/bitcoin/pull/14063

Test Plan:
Maybe not necessary because are "aesthetic changes", but just in case:

  1. Build with Clang in Debug mode:
CXX=clang++ CC=clang cmake .. -GNinja -DCMAKE_BUILD_TYPE=Debug
ninja check
  1. Verify that the compiler has not emitted a thread-safety warning.
  2. Run the node: ./src/bitcoind -regtest
  3. Verify that text similar to "Assertion failed: lock ... not held ..." is not printed on stderr.

Reviewers: Fabien, #bitcoin_abc, deadalnix, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D4149

Details

Provenance
practicalswift <practicalswift@users.noreply.github.com>Authored on Aug 25 2018, 22:56
fpelliccioniCommitted on Sep 25 2019, 12:41
fpelliccioniPushed on Sep 25 2019, 12:41
Reviewer
Restricted Project
Differential Revision
D4149: Move cs_main locking annotations from .cpp to .h
Parents
rABCf7bae40b393f: Merge #11220: Check specific validation error in miner tests
Branches
Unknown
Tags
Unknown