HomePhabricator

[Cashtab] Patch agora token switch issue

Description

[Cashtab] Patch agora token switch issue

Summary:
See T3721 for detailed description

If a user browses agora by manually switching the tokenId in the nav bar, the OrderBook component does not refresh offers with the updated tokenId. Patch.

Test Plan:
npm test

https://cashtab-local-dev.netlify.app/

I'm not sure how to directly test this, because react testing library does not support the user manually entering a new route (we would have to do it by clickling links in the app UI, and if we do this we force a refresh of the component and could not recreate the bug)

I've put this up on the test site. You can repeat the bug at cashtab.com now by

if you do the same thing on the test site (with this diff), you will not experience the issue. Hard refresh on load to ensure the latest version.

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D17512

Details

Provenance
bytesofmanAuthored on Sat, Jan 11, 14:23
bytesofmanPushed on Sat, Jan 11, 20:23
Reviewer
Restricted Project
Differential Revision
D17512: [Cashtab] Patch agora token switch issue
Parents
rABC02f6a143cd87: [Cashtab] [bugfix] Do not bring back old state on wallet change
Branches
Unknown
Tags
Unknown