HomePhabricator

tests: Use a default of supports_cli=True (instead of supports_cli=False)

Description

tests: Use a default of supports_cli=True (instead of supports_cli=False)

Summary:
Annotate functional tests supporting bitcoin-cli (--usecli) as such.
Change default supports_cli from False to True.

Before this commit:

$ test/functional/test_runner.py --usecli 2>&1 | cut -f2 -d'|' | grep -E ' (Passed|Skipped) *$' | sort | uniq -c
      8  ✓ Passed
    138  ○ Skipped

After:

$ ninja && test/functional/test_runner.py --usecli 2>&1 | cut -f2 -d'|' |     grep -E ' (Passed|Skipped) *$' | sort | uniq -c
[15/15] Linking CXX executable src/qt/bitcoin-qt
     97  ✓ Passed
     49  ○ Skipped

This is a backport of Core PR17675 [2/2]
https://github.com/bitcoin/bitcoin/pull/17675/commits/5ac804a9eb0cdbdcff8b50ecfb736f8793cab805

Depends on D8316

Test Plan: ninja && test/functional/test_runner.py --usecli

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D8317

Details

Provenance
practicalswift <practicalswift@users.noreply.github.com>Authored on Dec 6 2019, 13:22
PiRKCommitted on Nov 10 2020, 09:52
PiRKPushed on Nov 10 2020, 09:52
Reviewer
Restricted Project
Differential Revision
D8317: tests: Use a default of supports_cli=True (instead of supports_cli=False)
Parents
rABCae9a70765072: Fix macOS files description and add macos_appnap
Branches
Unknown
Tags
Unknown