HomePhabricator

[Cashtab] correct error in parsing tx history for op ret txs

Description

[Cashtab] correct error in parsing tx history for op ret txs

Summary:
T1847

Cashtab assumes that a tx with no address object in output is a token tx when parsing tx history. However, the tx could be a normal OP return tx.

This diff flags such a tx as non-token if no token info is available in the API check. Previous behavior failed on the error.

This does not impact utxo parsing, only tx history parsing.

Test Plan:

  1. DM me for a seed with such a tx in history to test, or send yourself a tx with an OP return output.
  2. Observe that the tx is parsed correctly.

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10102

Details

Provenance
Joey King <joseph.roy.king@gmail.com>Authored on Sep 13 2021, 15:45
bytesofmanPushed on Sep 13 2021, 16:17
Reviewer
Restricted Project
Differential Revision
D10102: [Cashtab] correct error in parsing tx history for op ret txs
Parents
rABC4a106b29a689: remove argName nBlocks from estimatefee RPC command registration
Branches
Unknown
Tags
Unknown