HomePhabricator

Merge #11491: [gui] Add proxy icon in statusbar

Authored by Jonas Schnelli <dev@jonasschnelli.ch> on May 16 2018, 08:07.

Description

Merge #11491: [gui] Add proxy icon in statusbar

Summary:
73cd5b25b [gui] Add proxy icon in statusbar (Cristian Mircea Messel)

Pull request description:

Relates to #7734

![image](https://user-images.githubusercontent.com/226170/33406640-8ea700c6-d576-11e7-9d69-fde9a696c219.png)

Please ignore the wrong alpha in the screenshot, I couldn't get the screenshot alpha right :(

I plan to extend this feature in future PRs to include:

- custom Tor icon
- clickable icon which opens network settings

Old proposals, dropped in favor of current

![image](https://user-images.githubusercontent.com/226170/32688635-979ef690-c6dd-11e7-8869-49da7e0f0a11.png)
![proxy_preview](https://user-images.githubusercontent.com/226170/31521305-99c43f22-afb1-11e7-9daf-d1ed6347daa8.png)
![image](https://user-images.githubusercontent.com/226170/31680585-72706098-b37d-11e7-88ad-028c4c723f42.png)

Tree-SHA512: e5f18c20c0be292256a3e78c91cdf390a3b6084346a192a8170460f706f5b6cd198ba5b0035798a85a442fe7f262cf1c2350064670085ff8f473f880ab5ba589

Backport of Core PR11491
https://github.com/bitcoin/bitcoin/pull/11491/

Test Plan:

make check
bitcoin-qt -proxy=<valid proxy>

However cursor over the P symbol in the bottom right corner until small window detailing proxy information appears.

bitcoin-qt

The P symbol should not appear because no proxy is being used.

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix, Fabien, jasonbcox

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D4269

Details

Committed
nakihitoOct 21 2019, 17:31
Pushed
nakihitoOct 21 2019, 17:31
Reviewer
Restricted Owners Package
Differential Revision
D4269: Merge #11491: [gui] Add proxy icon in statusbar
Parents
rABC40d9c234aa53: bugfix: Remove dangling wallet env instance and Delete walletView in…
Branches
Unknown
Tags
Unknown