HomePhabricator

[ecash-coinselect] Patch bug where returned outputs could be non-integer

Description

[ecash-coinselect] Patch bug where returned outputs could be non-integer

Summary:
Library must return outputs in satoshis, which must be integer values. Non-integer fee rates can create decimals.

Round up when calculating the fee as you must pay sufficient fee, and the output should be correspondingly lower as the fee is implied.

Test Plan: npm test

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D14916

Details

Provenance
bytesofmanAuthored on Dec 5 2023, 23:02
bytesofmanPushed on Dec 7 2023, 17:51
Reviewer
Restricted Project
Differential Revision
D14916: [ecash-coinselect] Patch bug where returned outputs could be non-integer
Parents
rABC5b83beb04735: [ecash-herald] Parse iceberg lowercase
Branches
Unknown
Tags
Unknown