util: Don't allow Base58 decoding of non-Base58 strings. Add Base58 tests.
bd611af6fa23
Actions

Description

util: Don't allow Base58 decoding of non-Base58 strings. Add Base58 tests.

Summary:

Don't allow Base58 decoding of non-Base58 strings. Add Base58 tests.

Backport of core PR17721.

Depends on D8153.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D8154

Details

Provenance

practicalswift <practicalswift@users.noreply.github.com>	Authored on Dec 11 2019, 10:56
Fabien	Committed on Oct 28 2020, 13:56
Fabien	Pushed on Oct 28 2020, 13:57

Reviewer

Restricted Project

Differential Revision

D8154: util: Don't allow Base58 decoding of non-Base58 strings. Add Base58 tests.

Parents

rABC1e72c9131884: tests: Add fuzzing harnesses for functions parsing scripts, numbers, JSON and…

Branches

Unknown

Tags

Unknown

Event Timeline

Fabien committed rABCbd611af6fa23: util: Don't allow Base58 decoding of non-Base58 strings. Add Base58 tests. (authored by practicalswift <practicalswift@users.noreply.github.com>).Oct 28 2020, 13:56

Fabien added an edge: D8154: util: Don't allow Base58 decoding of non-Base58 strings. Add Base58 tests..

Changes (4)

Path

Size

src/

test/

util/

rABCbd611af6fa23

View Options

src/base58.cpp

View Options

src/test/base58_tests.cpp

View Options

src/util/strencodings.cpp

View Options

util: Don't allow Base58 decoding of non-Base58 strings. Add Base58 tests.bd611af6fa23Actions

Description

Details

Event Timeline

Changes (4)

rABCbd611af6fa23

src/base58.cpp

src/test/base58_tests.cpp

src/util/strencodings.cpp

src/util/string.h

util: Don't allow Base58 decoding of non-Base58 strings. Add Base58 tests.
bd611af6fa23
Actions