HomePhabricator

refactor: remove unused assumeutxo methods

Description

refactor: remove unused assumeutxo methods

Summary:
After feedback from Russ, I realized that there are some extraneous assumeutxo methods
that are not necessary and probably just overly confusing. These include

  • Validated*()
  • IsBackgroundIBD()

and they can be removed.

Also add comment for g_best_block

This is a backport of core#21526 [2 & 3/12]
https://github.com/bitcoin/bitcoin/pull/21526/commits/ac4051d891e2d5c8ac130da16b85b9d880b44720
https://github.com/bitcoin/bitcoin/pull/21526/commits/665072a36df2e4c88705fedd4ac7c955d7f6a488

Backported out of order (unrelated refactorings first)

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D12267

Details

Provenance
James O'Beirne <james.obeirne@pm.me>Authored on Jul 15 2021, 14:40
PiRKCommitted on Oct 17 2022, 14:51
PiRKPushed on Oct 17 2022, 14:51
Reviewer
Restricted Project
Differential Revision
D12267: refactor: remove unused assumeutxo methods
Parents
rABCaca8b55dd2a9: p2p: log addrman consistency checks
Branches
Unknown
Tags
Unknown