HomePhabricator

[Cashtab] Implement unified balance header

Description

[Cashtab] Implement unified balance header

Summary:
Combine BalanceHeader and BalanceHeaderFiat into a cleaner, unit-tested component. Implement in App.js so it appears in the same position for all screens.

Note: This means the Settings screen how has the BalanceHeader at the top which, imo, is an improvment.

Features of new BalanceHeader

  • Hidden balance now controlled by css and not component replacement (faster)
  • Support for different user locale number formatting
  • Decimal places are now always constant (i.e. 2 decimal places for fiat and XEC, not sometimes 1)
  • Unit tested component
  • Unit tests for App.js

Test Plan: npm test

Reviewers: #bitcoin_abc, emack

Reviewed By: #bitcoin_abc, emack

Subscribers: emack

Differential Revision: https://reviews.bitcoinabc.org/D15205

Details

Provenance
bytesofmanAuthored on Jan 18 2024, 23:27
bytesofmanPushed on Jan 22 2024, 12:26
Reviewer
Restricted Project
Differential Revision
D15205: [Cashtab] Implement unified balance header
Parents
rABCbe684676739e: [e.cash] Add recommended security headers
Branches
Unknown
Tags
Unknown