HomePhabricator

Assert that RPCArg names are equal to CRPCCommand ones (net, rpcwallet)

Description

Assert that RPCArg names are equal to CRPCCommand ones (net, rpcwallet)

Summary:

This is the last part split out from #18531 to just touch some RPC methods. Description from the main pr:
Motivation

RPCArg names in the rpc help are currently only used for documentation. However, in the future they could be used to teach the server the named arguments. Named arguments are currently registered by the CRPCCommands and duplicate the RPCArg names from the documentation. This redundancy is fragile, and has lead to errors in the past (despite having linters to catch those kind of errors). See section "bugs found" for a list of bugs that have been found as a result of the changes here.
Changes

The changes here add an assert in the CRPCCommand constructor that the RPCArg names are identical to the ones in the CRPCCommand.

This is a backport of core#19994

Depends on D10340

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10341

Details

Provenance
PiRKAuthored on Oct 14 2021, 09:26
PiRKPushed on Oct 14 2021, 15:42
Reviewer
Restricted Project
Differential Revision
D10341: Assert that RPCArg names are equal to CRPCCommand ones (net, rpcwallet)
Parents
rABCc2cf6cba845d: fix CRPCCommand args in rpcwallet.cpp
Branches
Unknown
Tags
Unknown