HomePhabricator

net, rpc, test, bugfix: update GetNetworkName, GetNetworksInfo, regression tests

Description

net, rpc, test, bugfix: update GetNetworkName, GetNetworksInfo, regression tests

Summary:
PR description:

Following up on the BIP155 addrv2 changes, and starting with core#19845, RPC getnetworkinfo began returning networks with empty names.

This patch:

  • updates GetNetworkName() to the current Network enum
  • updates getNetworksInfo() to ignore as-yet unsupported networks
  • adds regression tests

This is a backport of core#20120

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10720

Details

Provenance
Jon Atack <jon@atack.com>Authored on Oct 12 2020, 07:31
PiRKCommitted on Dec 22 2021, 13:36
PiRKPushed on Dec 22 2021, 13:36
Reviewer
Restricted Project
Differential Revision
D10720: net, rpc, test, bugfix: update GetNetworkName, GetNetworksInfo, regression tests
Parents
rABCd4f10e131a98: Ignoring (but warn) on duplicate -wallet parameters
Branches
Unknown
Tags
Unknown