HomePhabricator

Fix getbestblockhash() called before the tip reaches the expected block

Description

Fix getbestblockhash() called before the tip reaches the expected block

Summary:
This fix a bug raised on CI (Teamcity #3004).
Analyzing the log shown that delay_node.getbestblockhash() was called
before its tip has been updated to alt_node_new_tip, which occured 3ms
later. Waiting for the tip to settle should avoid the issue.

Test Plan:

./test/functional/test_runner.py abc-finalize-block

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2221

Details

Provenance
FabienAuthored on Dec 23 2018, 13:31
FabienPushed on Dec 23 2018, 15:35
Reviewer
Restricted Project
Differential Revision
D2221: Fix getbestblockhash() called before the tip reaches the expected block
Parents
rABC8787bfd34ea4: [qa] Change connect_nodes_bi API to not assume an array of nodes.
Branches
Unknown
Tags
Unknown