HomePhabricator

refactor: Add interfaces::FoundBlock class to selectively return block data

Description

refactor: Add interfaces::FoundBlock class to selectively return block data

Summary:
FoundBlock class allows interfaces::Chain::findBlock to return more block
information without having lots of optional output parameters. FoundBlock class
is also used by other chain methods in upcoming commits.

There is mostly no change in behavior. Only exception is
CWallet::RescanFromTime now throwing NonFatalCheckError instead of
std::logic_error.

This is part [1/12] of Core PR17954 : https://github.com/bitcoin/bitcoin/pull/17954/commits/bf30cd4922ea62577d7bf63f5029e8be62665d45

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7864

Details

Provenance
Russell Yanofsky <russ@yanofsky.org>Authored on Feb 24 2020, 19:34
deadalnixCommitted on Oct 11 2020, 12:19
deadalnixPushed on Oct 11 2020, 12:19
Reviewer
Restricted Project
Differential Revision
D7864: refactor: Add interfaces::FoundBlock class to selectively return block data
Parents
rABCe6d44e7f1124: [backport#17261 13/13] Refactor: Replace SigningProvider pointers with…
Branches
Unknown
Tags
Unknown