Paths

Table of Contentst

Diffusion Bitcoin ABC c74463aa8e92

refactor: Replace string chain name constants with ChainTypes
c74463aa8e92
Actions

Tags

None

Subscribers

None

Description

refactor: Replace string chain name constants with ChainTypes

Summary:
This commit effectively moves the definition of these constants
out of the chainparamsbase to their own file.

Using the ChainType enums provides better type safety compared to
passing around strings.

The commit is part of an ongoing effort to decouple the libbitcoinkernel
library from the ArgsManager and other functionality that should not be
part of the kernel library.

Backport note: the Config ctor could also take a ChainType param instead of a network string but lets do this in a separate diff

This is a partial backport of core#27491
https://github.com/bitcoin/bitcoin/pull/27491/commits/ba8fc7d788932b25864fb260ca14983aa2398c23

Depends on D17987

Test Plan:
With Chronik compiled:
ninja all check-all bench-bitcoin bitcoin-fuzzers

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D17988

Details

Provenance

TheCharlatan <seb.kung@gmail.com>	Authored on Apr 17 2023, 20:20
PiRK	Committed on Sat, Apr 26, 12:05
PiRK	Pushed on Sat, Apr 26, 12:05

Reviewer

Restricted Project

Differential Revision

D17988: refactor: Replace string chain name constants with ChainTypes

Parents

rABCd40c68b72040: [cashtab] Transaction row UI

Branches

Unknown

Tags

Unknown

Event Timeline

PiRK committed rABCc74463aa8e92: refactor: Replace string chain name constants with ChainTypes (authored by TheCharlatan <seb.kung@gmail.com>).Sat, Apr 26, 12:05

PiRK added an edge: D17988: refactor: Replace string chain name constants with ChainTypes.

Changes (87)

Path

Size

chronik/

chronik-cpp/

src/

avalanche/

test/

stakingrewards_tests.cpp

bench/

coin_selection.cpp

load_external.cpp

mempool_stress.cpp

rpc_blockchain.cpp

rpc_mempool.cpp

bitcoin-chainstate.cpp

bitcoin-cli.cpp

bitcoin-wallet.cpp

chainparams.cpp

chainparamsbase.cpp

chainparamsbase.h

common/

kernel/

chainparams.cpp

mempool_args.cpp

networks/

abc/

checkpoints.cpp

pow/

test/

aserti32d_tests.cpp

grasberg_tests.cpp

qt/

networkstyle.cpp

paymentserver.cpp

test/

bitcoinaddressvalidatortests.cpp

guiutiltests.cpp

paymentservertests.cpp

rpc/

seeder/

test/

message_writer_tests.cpp

p2p_messaging_tests.cpp

test/

activation_tests.cpp

blockcheck_tests.cpp

blockmanager_tests.cpp

cashaddrenc_tests.cpp

checkpoints_tests.cpp

checkqueue_tests.cpp

config_tests.cpp

dnsseeds_tests.cpp

dstencode_tests.cpp

fuzz/

descriptor_parse.cpp

p2p_transport_deserializer.cpp

parse_univalue.cpp

script_sign.cpp

transaction.cpp

key_io_tests.cpp

miner_tests.cpp

settings_tests.cpp

util/

setup_common.cpp

validation_tests.cpp

util/

wallet/

test/

init_test_fixture.cpp

init_test_fixture.h

wallet_test_fixture.cpp

wallet_test_fixture.h

rABCc74463aa8e92

chronik/chronik-cpp/chronik.cpp

Loading...

src/avalanche/test/stakingrewards_tests.cpp

Loading...

src/bench/coin_selection.cpp

Loading...

src/bench/load_external.cpp

Loading...

src/bench/mempool_stress.cpp

Loading...

src/bench/rpc_blockchain.cpp

Loading...

src/bench/rpc_mempool.cpp

Loading...

src/bitcoin-chainstate.cpp

Loading...

src/bitcoin-cli.cpp

Loading...

src/bitcoin-tx.cpp

Loading...

src/bitcoin-wallet.cpp

Loading...

src/bitcoind.cpp

Loading...

src/chainparams.cpp

Loading...

src/chainparams.h

Loading...

src/chainparamsbase.cpp

Loading...

src/chainparamsbase.h

Loading...

src/common/args.cpp

Loading...

src/common/args.h

Loading...

src/common/configfile.cpp

Loading...

src/init.cpp

Loading...

src/kernel/chainparams.cpp

Loading...

src/kernel/chainparams.h

Loading...

src/mempool_args.cpp

Loading...

src/minerfund.cpp

Loading...

src/networks/abc/checkpoints.cpp

Loading...

src/pow/test/aserti32d_tests.cpp

Loading...

src/pow/test/daa_tests.cpp

Loading...

src/pow/test/eda_tests.cpp

Loading...

src/pow/test/grasberg_tests.cpp

Loading...

src/qt/bitcoin.cpp

Loading...

src/qt/guiutil.cpp

Loading...

src/qt/intro.cpp

Loading...

src/qt/networkstyle.cpp

Loading...

src/qt/networkstyle.h

Loading...

src/qt/paymentserver.cpp

Loading...

src/qt/rpcconsole.cpp

Loading...

src/qt/test/apptests.cpp

Loading...

src/qt/test/bitcoinaddressvalidatortests.cpp

Loading...

src/qt/test/guiutiltests.cpp

Loading...

src/qt/test/paymentservertests.cpp

Loading...

src/qt/test/test_main.cpp

Loading...

src/qt/test/uritests.cpp

Loading...

src/rpc/blockchain.cpp

Loading...

src/rpc/mining.cpp

Loading...

src/rpc/net.cpp

Loading...

src/seeder/main.cpp

Loading...

src/seeder/options.cpp

Loading...

src/seeder/test/message_writer_tests.cpp

Loading...

src/seeder/test/p2p_messaging_tests.cpp

Loading...

src/test/activation_tests.cpp

Loading...

src/test/blockcheck_tests.cpp

Loading...

src/test/blockmanager_tests.cpp

Loading...

src/test/cashaddrenc_tests.cpp

Loading...

src/test/checkpoints_tests.cpp

Loading...

src/test/checkqueue_tests.cpp

Loading...

src/test/config_tests.cpp

Loading...

src/test/dnsseeds_tests.cpp

Loading...

src/test/dstencode_tests.cpp

Loading...

src/test/fuzz/block.cpp

Loading...

src/test/fuzz/descriptor_parse.cpp

Loading...

src/test/fuzz/integer.cpp

Loading...

src/test/fuzz/key.cpp

Loading...

src/test/fuzz/key_io.cpp

Loading...

src/test/fuzz/message.cpp

Loading...

src/test/fuzz/net.cpp

Loading...

src/test/fuzz/p2p_transport_deserializer.cpp

Loading...

src/test/fuzz/parse_univalue.cpp

Loading...

src/test/fuzz/pow.cpp

Loading...

src/test/fuzz/script.cpp

Loading...

src/test/fuzz/script_sign.cpp

Loading...

src/test/fuzz/system.cpp

Loading...

src/test/fuzz/transaction.cpp

Loading...

src/test/key_io_tests.cpp

Loading...

src/test/key_tests.cpp

Loading...

src/test/miner_tests.cpp

Loading...

src/test/settings_tests.cpp

Loading...

src/test/undo_tests.cpp

Loading...

src/test/util/setup_common.cpp

Loading...

src/test/util/setup_common.h

Loading...

src/test/util_tests.cpp

Loading...

src/test/validation_tests.cpp

Loading...

src/util/settings.cpp

Loading...

src/util/settings.h

Loading...

src/wallet/test/init_test_fixture.cpp

Loading...

src/wallet/test/init_test_fixture.h

Loading...

src/wallet/test/wallet_test_fixture.cpp

Loading...

src/wallet/test/wallet_test_fixture.h

Loading...