HomePhabricator

[test] Don't set bypass_limits to true in txvalidation[cache]_tests.cpp

Description

[test] Don't set bypass_limits to true in txvalidation[cache]_tests.cpp

Summary:

[test] Don't set bypass_limits to true in txvalidatiocache_tests.cpp

AcceptToMemoryPool() is called for transactions with fees above
minRelayTxFee and with the mempool not full, so setting bypass_limits to
true or false has no impact on the test.

The only way that changing bypass_limits from true to false could change
the result would be to change the outcome to INVALID(TX_MEMPOOL_POLICY).
Since all the ATMP calls in this test result in VALID both before and
after this change, there is no change in behavior.

https://github.com/bitcoin/bitcoin/pull/23173/commits/497c9e29640858bb3beb20089c2d4f9e133c7e42

[test] Don't set bypass_limits to true in txvalidation_tests.cpp

AcceptToMemoryPool() is called for an invalid coinbase transaction, so
setting bypass_limits to true or false has no impact on the test.

The only way that changing bypass_limits from true to false could change
the result would be to change the outcome to INVALID(TX_MEMPOOL_POLICY).
Since the ATMP call in this test results in INVALID(TX_CONSENSUS) both
before and after this change, there is no change in behavior.

This is a backport of core#23173
https://github.com/bitcoin/bitcoin/pull/23173/commits/5759fd12b8d5937e9187fa33489a95b1d8e6d1e5

Test Plan: ninja check

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D12232

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on Sep 27 2021, 15:40
PiRKCommitted on Oct 13 2022, 16:22
PiRKPushed on Oct 13 2022, 16:22
Reviewer
Restricted Project
Differential Revision
D12232: [test] Don't set bypass_limits to true in txvalidation[cache]_tests.cpp
Parents
rABC2693900982a3: wallet: Reorder locks in dumpwallet to avoid lock order assertion
Branches
Unknown
Tags
Unknown