Consistently use the calculate_shortid facility in functional tests

Summary: I figured out that the function exists, so let's use it. There is no change in behavior.

Test Plan:

ninja check-functional

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D11573