HomePhabricator

Drop UpdateTransaction in favor of UpdateInput

Description

Drop UpdateTransaction in favor of UpdateInput

Summary:
Updating the input explicitly requires the caller to present a mutable
input, which more clearly communicates the effects and intent of the method.

In most cases, this input is already immediately available and need not be
looked up.

This is a backport of Core PR13269

Depends on D4200

Test Plan:

make check
./test/functional/test_runner.py

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D4203

Details

Provenance
Ben Woosley <ben.woosley@gmail.com>Authored on May 18 2018, 00:54
deadalnixCommitted on Oct 4 2019, 21:38
deadalnixPushed on Oct 4 2019, 21:38
Reviewer
Restricted Project
Differential Revision
D4203: Drop UpdateTransaction in favor of UpdateInput
Parents
rABC8f425f2d3013: Generic TransactionSignatureCreator works with both CTransaction and…
Branches
Unknown
Tags
Unknown