HomePhabricator

[SECP256K1] Use bit ops instead of int mult for constant-time logic in…

Description

[SECP256K1] Use bit ops instead of int mult for constant-time logic in gej_add_ge

Summary:

Nothing is wrong with the current implementation. But it looks out of
place because we generally prefer bit operations because they're faster
and are more likely constant-time.

Backport of secp256k1#882

Test Plan:

ninja check-secp256k1

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D9388

Details

Provenance
Tim Ruffing <crypto@timruffing.de>Authored on Jan 28 2021, 15:57
FabienCommitted on Apr 8 2021, 17:18
FabienPushed on Apr 8 2021, 17:21
Reviewer
Restricted Project
Differential Revision
D9388: [SECP256K1] Use bit ops instead of int mult for constant-time logic in gej_add_ge
Parents
rABCa5c12c9a2c57: [avalanche] delay executing avalanche event loop until IBD is done
Branches
Unknown
Tags
Unknown