HomePhabricator

Remove confusing P1008R1 violation in ATMPArgs

Description

Remove confusing P1008R1 violation in ATMPArgs

Summary:
This is a backport of core#24404

Note that without this change, the compiler raises errors when trying to compile with set(CMAKE_CXX_STANDARD 20)

/home/pierre/dev/bitcoin-abc/src/validation.cpp: In static member function ‘static {anonymous}::MemPoolAccept::ATMPArgs {anonymous}::MemPoolAccept::ATMPArgs::SingleAccept(const Config&, int64_t, bool, std::vector<COutPoint>&, bool, unsigned int)’:
/home/pierre/dev/bitcoin-abc/src/validation.cpp:332:59: error: no matching function for call to ‘{anonymous}::MemPoolAccept::ATMPArgs::ATMPArgs(<brace-enclosed initializer list>)’
  332 |                             /*m_package_submission=*/false};
      |                                                           ^
/home/pierre/dev/bitcoin-abc/src/validation.cpp:299:12: note: candidate: ‘constexpr {anonymous}::MemPoolAccept::ATMPArgs::ATMPArgs(const {anonymous}::MemPoolAccept::ATMPArgs&)’
  299 |     struct ATMPArgs {
      |            ^~~~~~~~
/home/pierre/dev/bitcoin-abc/src/validation.cpp:299:12: note:   candidate expects 1 argument, 7 provided

Depends on D15313

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D15314

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Feb 21 2022, 11:24
PiRKCommitted on Jan 30 2024, 13:58
PiRKPushed on Jan 30 2024, 13:58
Reviewer
Restricted Project
Differential Revision
D15314: Remove confusing P1008R1 violation in ATMPArgs
Parents
rABC20d99cc6345c: Use designated initializers for ChainstateManager::Options and move into…
Branches
Unknown
Tags
Unknown