HomePhabricator

[Cashtab] Patch cancel vs buy distinction in agora partials

Description

[Cashtab] Patch cancel vs buy distinction in agora partials

Summary:
Realized previous mock was wrong after testing some cancels. Seems like the isCanceled check is only for ONESHOT, need a better check for partials.

The check here is from guess and check, test driven. Works without breaking previous tests, except for one previous test that actually was a cancel, and should be broken.

Test Plan:
npm test, see screenshots

patches bought amount for agora buys (before this diff, rendered as "bought 50")
before:

image.png (196×458 px, 23 KB)

after:
image.png (202×470 px, 24 KB)

patches cancels previously mis-parsed as buys
before:

image.png (175×450 px, 22 KB)

after:
image.png (186×469 px, 18 KB)

Reviewers: #bitcoin_abc, emack

Reviewed By: #bitcoin_abc, emack

Differential Revision: https://reviews.bitcoinabc.org/D16998

Details

Provenance
bytesofmanAuthored on Oct 25 2024, 03:43
bytesofmanPushed on Oct 25 2024, 12:42
Reviewer
Restricted Project
Differential Revision
D16998: [Cashtab] Patch cancel vs buy distinction in agora partials
Parents
rABC8cabfa5c8575: [chronik] store a scripthash -> script index
Branches
Unknown
Tags
Unknown