HomePhabricator

Move blockstorage-related unload to BlockManager::Unload

Description

Move blockstorage-related unload to BlockManager::Unload

Summary:
This is a refactor and safe to do because:

  • UnloadBlockIndex calls ChainstateManager::Unload, which calls BlockManager::Unload
  • Only unit tests call Unload directly

This is a partial backport of core#23974
https://github.com/bitcoin/bitcoin/pull/23974/commits/fab262174b96854d2df5bee7da578990c9e9cb1e

Depends on D12511

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, sdulfari

Reviewed By: #bitcoin_abc, sdulfari

Differential Revision: https://reviews.bitcoinabc.org/D12512

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Jan 5 2022, 15:23
PiRKCommitted on Nov 17 2022, 10:06
PiRKPushed on Nov 17 2022, 10:07
Reviewer
Restricted Project
Differential Revision
D12512: Move blockstorage-related unload to BlockManager::Unload
Parents
rABC64321b46c04e: move-only: Create WriteBlockIndexDB helper
Branches
Unknown
Tags
Unknown