HomePhabricator

httpserver: explicitly detach worker threads

Description

httpserver: explicitly detach worker threads

When using std::thread in place of boost::thread, letting the threads destruct
results in a std::terminate. According to the docs, the same thing should be
be happening in later boost versions:
http://www.boost.org/doc/libs/1_55_0/doc/html/thread/thread_management.html#thread.thread_management.thread.destructor

I'm unsure why this hasn't blown up already, but explicitly detaching can't
hurt.

Details

Provenance
Cory Fields <cory-nospam-@coryfields.com>Authored on Jul 28 2016, 22:21
deadalnixPushed on May 14 2017, 22:04
Parents
rABC755aa05174e0: httpserver: use a future rather than relying on boost's try_join_for
Branches
Unknown
Tags
Unknown

Event Timeline

Cory Fields <cory-nospam-@coryfields.com> committed rABCd3773ca9aeb0: httpserver: explicitly detach worker threads (authored by Cory Fields <cory-nospam-@coryfields.com>).Jul 28 2016, 23:07