HomePhabricator

[Cashtab][Alias] Deprecate alias caching mechanism

Description

[Cashtab][Alias] Deprecate alias caching mechanism

Summary:
T3216

Depends on D14322

All component dependencies on the previous alias caching mechanism have now been deprecated. This diff removes the remaining un-used alias caching logic and unit tests.

Test Plan:

  • grep -r aliasCache src/
  • grep -r getAliasesFromLocalForage src/
  • npm test
  • set alias flag to true in Ticker.js
  • npm start
  • open an existing wallet with the previous aliasCache in localForage and ensure no caching errors in the console log (simulating the majority of current users)
  • delete cashtabCache in localForage, reload Cashtab and note the cashtabCache successfully updated message in the console log, along with no sign of aliasCache object in cashtabCache
  • verify tokenInfoById in cashtabCache is correctly populated with tokens held by the wallet
  • create a new wallet, observe no caching errors in console log and no aliasCache object in cashtabCache
  • import a wallet, observe no caching errors in console log and correct cashtabCache structure
  • set the alias flag set to false in Ticker.js and reload Cashtab and ensure no caching errors in console log

Reviewers: bytesofman, #bitcoin_abc, Fabien

Reviewed By: bytesofman, #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D14323

Details

Provenance
emackAuthored on Jul 29 2023, 05:54
emackPushed on Jul 31 2023, 22:55
Reviewer
Restricted Project
Differential Revision
D14323: [Cashtab][Alias] Deprecate alias caching mechanism
Parents
rABC969bca33c25a: [Cashtab][Alias] Deprecate getAddressFromAlias
Branches
Unknown
Tags
Unknown