HomePhabricator

net: Remove un-actionable TODO

Description

net: Remove un-actionable TODO

Summary:

The first commit removes a TODO that is infeasible to solve. Currently, most (de)serializable classes in Bitcoin Core have public members. For example CMessageHeader, FlatFilePos, CBlock, CTransaction, CCoin, ...

So either this TODO comment should apply to all classes or to none. Fix that discrepancy by removing it from the source code for now. If deemed important, the TODO can be discussed in a brainstorming issue later.

Backport note: the second commit is about style. Some changes go against ABC style guidelines, the rest are already applied.

This is a backport of Core PR18996

Test Plan: ninja && ninja check

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D9138

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on May 17 2020, 14:21
PiRKCommitted on Feb 3 2021, 14:15
PiRKPushed on Feb 3 2021, 14:15
Reviewer
Restricted Project
Differential Revision
D9138: net: Remove un-actionable TODO
Parents
rABC349a39d18aa6: [Cashtab] Typo fix
Branches
Unknown
Tags
Unknown

Event Timeline