HomePhabricator

Accept any sequence of PUSHDATAs in OP_RETURN outputs
da894ab5da22Unpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Accept any sequence of PUSHDATAs in OP_RETURN outputs

Previously only one PUSHDATA was allowed, needlessly limiting
applications such as matching OP_RETURN contents with bloom filters that
operate on a per-PUSHDATA level. Now any combination that passes
IsPushOnly() is allowed, so long as the total size of the scriptPubKey
is less than 42 bytes. (unchanged modulo non-minimal PUSHDATA encodings)

Also, this fixes the odd bug where previously the PUSHDATA could be
replaced by any single opcode, even sigops consuming opcodes such as
CHECKMULTISIG. (20 sigops!)

Details

Provenance
Peter Todd <pete@petertodd.org>Authored on Oct 13 2014, 14:18
Jorge Timón <jtimon@jtimon.cc>Committed on Oct 1 2015, 16:28
deadalnixPushed on May 14 2017, 22:04
Parents
rABC5d8709c3b7fc: Add IsPushOnly(const_iterator pc)
Branches
Unknown
Tags
Unknown

Event Timeline

Jorge Timón <jtimon@jtimon.cc> committed rABCda894ab5da22: Accept any sequence of PUSHDATAs in OP_RETURN outputs (authored by Peter Todd <pete@petertodd.org>).Oct 1 2015, 16:28