HomePhabricator

Eliminate unnecessary call to CheckBlock
dbb89dc793b0Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Eliminate unnecessary call to CheckBlock

ProcessNewBlock would return failure early if CheckBlock failed, before
calling AcceptBlock. AcceptBlock also calls CheckBlock, and upon failure
would update mapBlockIndex to indicate that a block was failed. By returning
early in ProcessNewBlock, we were not marking blocks that fail a check in
CheckBlock as permanently failed, and thus would continue to re-request and
reprocess them.

Details

Provenance
Suhas Daftuar <sdaftuar@gmail.com>Authored on Dec 17 2015, 18:45
deadalnixPushed on May 14 2017, 22:04
Parents
rABC196ad6913ff5: Merge #7451: Add link to bitcoin whitepaper
Branches
Unknown
Tags
Unknown

Event Timeline

Suhas Daftuar <sdaftuar@gmail.com> committed rABCdbb89dc793b0: Eliminate unnecessary call to CheckBlock (authored by Suhas Daftuar <sdaftuar@gmail.com>).Feb 1 2016, 19:29