HomePhabricator

[backport#17328] GuessVerificationProgress: cap the ratio to 1

Description

[backport#17328] GuessVerificationProgress: cap the ratio to 1

Summary:
2f5f7d6b135e4eab368bbafd9e6e979aa72398de GuessVerificationProgress: cap the ratio to 1 (darosior)

Pull request description:

Noticed `getblockchaininfo` would return a `verificationprogress` > 1, especially while generating. This caps the verification progress to `1`.

Tried to append a check to functional tests but this would pass even without the patch, so it seems better to not add a superfluous check (but this can easily be reproduced by trying to generate blocks in the background and `watch`ing `getblockchainfo`).

Backport of Core PR17328

Test Plan:

ninja all check check-functional

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D8755

Details

Provenance
Wladimir J. van der Laan <laanwj@protonmail.com>Authored on Nov 18 2019, 13:13
majcostaCommitted on Dec 24 2020, 16:07
majcostaPushed on Dec 24 2020, 16:07
Reviewer
Restricted Project
Differential Revision
D8755: [backport#17328] GuessVerificationProgress: cap the ratio to 1
Parents
rABC48b5e2d8d8ce: [backport#16805] logs: add timing information to FlushStateToDisk()
Branches
Unknown
Tags
Unknown