HomePhabricator

Move m_failed_blocks to ChainstateManager

Description

Move m_failed_blocks to ChainstateManager

Summary:
The member is unrelated to block storage (BlockManager). It is related
to validation.

Fix the confusion by moving it.

Can be reviewed with
--color-moved=dimmed-zebra --color-moved-ws=ignore-all-space

This is a partial backport of core#23785
https://github.com/bitcoin/bitcoin/pull/23785/commits/facd2137eceacb95e1f71c87ddc704d752b37272

Depends on D12485

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D12486

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Nov 23 2021, 18:44
PiRKCommitted on Nov 16 2022, 13:58
PiRKPushed on Nov 16 2022, 13:58
Reviewer
Restricted Project
Differential Revision
D12486: Move m_failed_blocks to ChainstateManager
Parents
rABCefb457b0ee6e: Move AcceptBlockHeader to ChainstateManager
Branches
Unknown
Tags
Unknown