HomePhabricator
Diffusion Bitcoin ABC e0169349a9a2

[Cashtab] Replace toBitcoinCash function
e0169349a9a2
Actions

Description

[Cashtab] Replace toBitcoinCash function

Summary: Replace toBitcoinCash function with new fromSmallestDenomination function that accepts cashDecimals parameter. Add unit tests to confirm this replacement does not change the output of previous function.

Test Plan: npm test

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D9280

Details

Provenance
Joey King <joseph.roy.king@gmail.com>Authored on Feb 26 2021, 18:54
bytesofmanPushed on Feb 26 2021, 19:46
Reviewer
Restricted Project
Differential Revision
D9280: [Cashtab] Replace toBitcoinCash function
Parents
rABCe98dd8358d9c: test: type hints in Python tests
Branches
Unknown
Tags
Unknown

Event Timeline

Joey King <joseph.roy.king@gmail.com> committed rABCe0169349a9a2: [Cashtab] Replace toBitcoinCash function (authored by Joey King <joseph.roy.king@gmail.com>).Feb 26 2021, 19:46
Joey King <joseph.roy.king@gmail.com> added an edge: D9280: [Cashtab] Replace toBitcoinCash function.
teamcity mentioned this in Unknown Object (Maniphest Task).Feb 26 2021, 20:06

Changes (4)

PathSize
web/
cashtab/
src/
hooks/
__tests__/
utils/
__tests__/

rABCe0169349a9a2

View Options

web/cashtab/src/hooks/__tests__/migrations.test.js

Loading...
View Options

web/cashtab/src/hooks/useWallet.js

Loading...
View Options

web/cashtab/src/utils/__tests__/cashMethods.test.js

Loading...
View Options

web/cashtab/src/utils/cashMethods.js

Loading...