HomePhabricator

Fix memleak in TorController [rework]
e2195037116fUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fix memleak in TorController [rework]

It looks like, TorController::disconnected_cb(TorControlConnection&
conn) gets called multiple times which results in multiple event_new().

Avoid this by creating the event only once in the constructore, and
deleting it only once in the destructor (thanks to Cory Fields for the
idea).

Replaces the fix by Jonas Schnelli in #7610, see discussion there.

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Mar 3 2016, 12:28
deadalnixPushed on May 14 2017, 22:04
Parents
rABC1b68de35250e: Merge #7620: [travis] Only run check-doc.py once
Branches
Unknown
Tags
Unknown

Event Timeline

Wladimir J. van der Laan <laanwj@gmail.com> committed rABCe2195037116f: Fix memleak in TorController [rework] (authored by Wladimir J. van der Laan <laanwj@gmail.com>).Mar 3 2016, 12:31