HomePhabricator

[Cashtab] Update SignVerifyMsg with direct calls to antd notifications

Description

[Cashtab] Update SignVerifyMsg with direct calls to antd notifications

Summary:
This is a precursor to fully deprecating Notifications.js.

Previous efforts to consolidate all notification permutations into a single function have yielded little efficiency compared to simply straight-up using the antd component as per this diff.

Having said that, directly calling the antd notification component also introduces challenges in inserting the data-testid tags needed for automated integration tests to work. However this was mitigated by using the queryByText API to locate the resulting notification for test verification.

Test Plan:

  • npm test
  • grep -r messageSignedNotification src/ with no output
  • grep -r MessageSignedNotificationIcon src/ with no output
  • npm start
  • Navigate to the Sign & Verify component and trigger the following notifications:
  • Signature generation success

before

image.png (144×404 px, 13 KB)
after
image.png (146×406 px, 18 KB)

  • Signature verification success (no change to UI)
  • Signature verification failure (no change to UI)
  • load d15305.netlify.app on mobile device and verify the above
  • npm run extension and verify the above on extension

Reviewers: #bitcoin_abc, bytesofman

Reviewed By: #bitcoin_abc, bytesofman

Differential Revision: https://reviews.bitcoinabc.org/D15305

Details

Provenance
emackAuthored on Jan 28 2024, 10:53
emackPushed on Feb 1 2024, 00:24
Reviewer
Restricted Project
Differential Revision
D15305: [Cashtab] Update SignVerifyMsg with direct calls to antd notifications
Parents
rABC134f73f09b04: [Cashtab] Improve formatting of useWallet tests
Branches
Unknown
Tags
Unknown