HomePhabricator

log: improve checkaddrman logging with duration in milliseconds

Description

log: improve checkaddrman logging with duration in milliseconds

Summary:

log, timer: allow not repeating log message on completion

log, timer: add LOG_TIME_MILLIS_WITH_CATEGORY_MSG_ONCE macro

that prints the descriptive message when logging the start
but not when logging the completion.

p2p: improve checkaddrman logging with duration in milliseconds

and update the function name to CheckAddrman (drop "Force") for
nicer log output as it is prefixed to each of these log messages:

2021-09-21T18:42:50Z [opencon] CheckAddrman: new 64864, tried 1690, total 66554 started
2021-09-21T18:42:50Z [opencon] CheckAddrman: completed (76.21ms)

The existing Doxygen documentation on the function already makes
clear that it is unaffected by m_consistency_check_ratio.

This is a backport of core#22872

Test Plan:
ninja all check-all

src/bitcoind -debug=addrman -checkaddrman=10

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D12469

Details

Provenance
Jon Atack <jon@atack.com>Authored on Sep 11 2021, 18:32
PiRKCommitted on Nov 11 2022, 03:31
PiRKPushed on Nov 11 2022, 03:31
Reviewer
Restricted Project
Differential Revision
D12469: log: improve checkaddrman logging with duration in milliseconds
Parents
rABC448a91fef4e4: Remove CTxMemPool params from ATMP
Branches
Unknown
Tags
Unknown