HomePhabricator

[ecash-lib] Support address key in target outputs

Description

[ecash-lib] Support address key in target outputs

Summary:
Explored preparing all targetOutputs with Script in Cashtab (see D16427).

While this is doable, it is a weird API to standardize. Most developers will be working with address. For example, scanning QR codes gets an address. User copy paste entry is expected to be an address (or maybe an alias).

Expecting developers to always convert to ecash-lib Script type before calling the library is unreasonable. ecash-lib should just handle address.

Test Plan: npm test, CI

Reviewers: #bitcoin_abc, Fabien, tobias_ruck

Reviewed By: #bitcoin_abc, Fabien, tobias_ruck

Subscribers: tobias_ruck, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D16428

Details

Provenance
bytesofmanAuthored on Jul 5 2024, 22:20
bytesofmanPushed on Jul 9 2024, 12:14
Reviewer
Restricted Project
Differential Revision
D16428: [ecash-lib] Support address key in target outputs
Parents
rABCb81cd4c29fd7: test: Run mempool_packages.py with MiniWallet
Branches
Unknown
Tags
Unknown