Paths

Table of Contentst

Diffusion Bitcoin ABC e63a388c3f04

Use DataStream where possible
e63a388c3f04
Actions

Tags

None

Subscribers

None

Description

Use DataStream where possible

Summary:
This replaces CDataStream with DataStream everywhere where it doesn't cause a compilation failure (i.e no downstream code is calling ss.Get/SetVersion or ss.Get/SetType).

This concludes backport of core#25296
https://github.com/bitcoin/bitcoin/pull/25296/commits/fa29e73cdab82f98682821322cda89b1084ba887
https://github.com/bitcoin/bitcoin/pull/25296/commits/fa035fe2d61d0c98d1bfd0153a0c3b5eb9d40de4
Depends on D18947

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D18948

Details

Provenance

PiRK	Authored on Sat, Nov 15, 12:27
PiRK	Pushed on Tue, Nov 18, 11:22

Reviewer

Restricted Project

Differential Revision

D18948: Use DataStream where possible

Parents

rABC374ef2a303e9: streams: Add DataStream without ser-type and ser-version

Branches

Unknown

Tags

Unknown

Event Timeline

PiRK committed rABCe63a388c3f04: Use DataStream where possible (authored by PiRK).Tue, Nov 18, 11:22

PiRK added an edge: D18948: Use DataStream where possible.

Changes (57)

Path

Size

chronik/

chronik-cpp/

chronik_bridge.cpp

test/

bridgeprimitives_tests.cpp

chronikbridge_tests.cpp

src/

avalanche/

test/

compactproofs_tests.cpp

bench/

load_external.cpp

rpc_blockchain.cpp

blockencodings.cpp

common/

iguana/

kernel/

qt/

recentrequeststablemodel.cpp

walletmodel.cpp

rpc/

test/

blockencodings_tests.cpp

blockfilter_tests.cpp

bloom_tests.cpp

checkpoints_tests.cpp

coins_tests.cpp

crypto_tests.cpp

fuzz/

prevector_tests.cpp

script_tests.cpp

serialize_intcode_tests.cpp

serialize_tests.cpp

sigcache_tests.cpp

sighash_tests.cpp

sighashtype_tests.cpp

streams_tests.cpp

transaction_tests.cpp

txpackage_tests.cpp

uint256_tests.cpp

util/

setup_common.cpp

wallet/

rpc/

test/

psbt_wallet_tests.cpp

rABCe63a388c3f04

chronik/chronik-cpp/chronik_bridge.cpp

Loading...

chronik/test/bridgeprimitives_tests.cpp

Loading...

chronik/test/chronikbridge_tests.cpp

Loading...

src/avalanche/delegation.cpp

Loading...

src/avalanche/proof.cpp

Loading...

src/avalanche/test/compactproofs_tests.cpp

Loading...

src/bench/checkblock.cpp

Loading...

src/bench/load_external.cpp

Loading...

src/bench/prevector.cpp

Loading...

src/bench/rpc_blockchain.cpp

Loading...

src/blockencodings.cpp

Loading...

src/common/bloom.cpp

Loading...

src/core_read.cpp

Loading...

src/core_write.cpp

Loading...

src/dbwrapper.h

Loading...

src/iguana/iguana.cpp

Loading...

src/kernel/coinstats.cpp

Loading...

src/kernel/coinstats.h

Loading...

src/qt/recentrequeststablemodel.cpp

Loading...

src/qt/walletmodel.cpp

Loading...

src/rest.cpp

Loading...

src/rpc/avalanche.cpp

Loading...

src/rpc/blockchain.cpp

Loading...

src/rpc/txoutproof.cpp

Loading...

src/streams.h

Loading...

src/test/blockencodings_tests.cpp

Loading...

src/test/blockfilter_tests.cpp

Loading...

src/test/bloom_tests.cpp

Loading...

src/test/checkpoints_tests.cpp

Loading...

src/test/coins_tests.cpp

Loading...

src/test/crypto_tests.cpp

Loading...

src/test/fuzz/float.cpp

Loading...

src/test/fuzz/integer.cpp

Loading...

src/test/fuzz/key.cpp

Loading...

src/test/fuzz/prevector.cpp

Loading...

src/test/fuzz/string.cpp

Loading...

src/test/key_tests.cpp

Loading...

src/test/pmt_tests.cpp

Loading...

src/test/prevector_tests.cpp

Loading...

src/test/script_tests.cpp

Loading...

src/test/serialize_intcode_tests.cpp

Loading...

src/test/serialize_tests.cpp

Loading...

src/test/sigcache_tests.cpp

Loading...

src/test/sighash_tests.cpp

Loading...

src/test/sighashtype_tests.cpp

Loading...

src/test/streams_tests.cpp

Loading...

src/test/transaction_tests.cpp

Loading...

src/test/txpackage_tests.cpp

Loading...

src/test/uint256_tests.cpp

Loading...

src/test/util/setup_common.cpp

Loading...

src/wallet/bdb.cpp

Loading...

src/wallet/bdb.h

Loading...

src/wallet/db.h

Loading...

src/wallet/rpc/backup.cpp

Loading...

src/wallet/sqlite.cpp

Loading...

src/wallet/sqlite.h

Loading...

src/wallet/test/psbt_wallet_tests.cpp

Loading...